https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2223

This seems very dangerous since it will continue block across a disconnection/new connection. Is that the intended use case?
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2224

Yeah, I mentioned the risks to the requester (Nelgin) and he tested and was okay with the change: upon disconnect, the modem is always sending *something* to the application (SexPOTS), so it always aborts this loop. Still, I made the default timeout non-zero (60 seconds).
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2225

While that works fine for his modem usage, I don't understand why he needs more than the 68 years allowed by the timeout value.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2226

I'm also not sure why his ask is important enough to potentially break existing consumers and/or add a special-case value.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2227

I think passing INT_MAX for infinite timeout would be *much* better than zero. --- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2228

I did search and could not locate any caller of this function with a timeout parameter value of 0. Seemed like a safe-enough change but using INT_MAX or INT_MIN is fine too.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

On Mon, 24 Jan 2022 15:55:48 -0800
"Deuc_" <deuc_@VERT> wrote:

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2225

While that works fine for his modem usage, I don't understand why he
needs more than the 68 years allowed by the timeout value.

If someone had told me I cannot have an invite timeout but if you set
it to 0 then it'll be 68 years, I'd have been fine with that.
--
End Of The Line BBS - Plano, TX
telnet endofthelinebbs.com 23
---
þ Synchronet þ End Of The Line BBS - endofthelinebbs.com
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)