has anyone else noticed that makenl is generating 10 character serial numbers?

Opening 4515.msg
Subj: net135.seg received
Attr: 0x0189 (PRIVATE, SENT, KILLSENT, LOCAL)
To : Coordinator (1.135/0.0)
From: MakeNL 3.4.8 (1.18/0.0)
Time: 27 Jul 19 05:38:31
@INTL 1:135/0 1:18/0
MSGID: 1:18/0 58585858f0
Your nodelist update 'net135.seg' has been received and processed without error.


Opening 4516.msg
Subj: net3634.seg received
Attr: 0x0185 (PRIVATE, RECV, KILLSENT, LOCAL)
To : Coordinator (1.3634/0.0)
From: MakeNL 3.4.8 (1.18/0.0)
Time: 27 Jul 19 05:38:31
@INTL 1:3634/0 1:18/0
MSGID: 1:18/0 58585858f1
Your nodelist update 'net3634.seg' has been received and processed without error.


Opening 4517.msg
4517.msg !Message missing terminator (0A instead of 00)
Subj: /home/sbbs/fidonet/makenlng/fidonet/R18/master/r18s.208
Attr: 0x0199 (PRIVATE, SENT, FILE, KILLSENT, LOCAL)
To : Coordinator (1.229/426.0)
From: MakeNL 3.4.8 (1.18/0.0)
Time: 27 Jul 19 05:38:41
@INTL 1:229/426 1:18/0
MSGID: 1:18/0 58585858f3


)\/(ark

Once men turned their thinking over to machines in the hope that this would set them free. But that only permitted other men with machines to enslave them.
... Do we care? A-Are we caring about that?
---
* Origin: (1:3634/12.73)

Hi! mark,

On 07/29/2019 04:14 AM, you wrote:

has anyone else noticed that makenl is generating 10 character serial numbers?

Still okay with MakeNL 3.4.8 (Linux) compiled with GNU C on Oct 20 2018 21:07:21.

For months I've been meaning to update but maybe I shouldn't.

Cheers,
Paul.

--- Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
* Origin: Right rudder, left stick. Wheeeeee! (3:640/1384.125)

Re: makenl msgids
By: Paul Quinn to mark lewis on Mon Jul 29 2019 08:47:18

has anyone else noticed that makenl is generating 10 character serial numbers?

Still okay with MakeNL 3.4.8 (Linux) compiled with GNU C on Oct 20 2018

21:07:21.

interesting... mine is also 3.4.8... compiled 2018 Oct 22 with gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0... hummm... are you 32bit or 64bit?

$ file makenl
makenl: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/l, for GNU/Linux 3.2.0, BuildID[sha1]=f72955475c5d68939c7ec93764e44299dd632d4b, stripped

)\/(ark
--- SBBSecho 3.08-Linux
* Origin: SouthEast Star Mail HUB - SESTAR (1:3634/12)

Hello mark,

has anyone else noticed that makenl is generating 10 character serial numbers?

Mine is version 2.5.0 compiled a short time ago and is generating an 8 character MSGID.

Ttyl :-),
Al

--- GoldED+/LNX 1.1.5-b20180707
* Origin: The Rusty MailBox - Penticton, BC Canada (1:153/757)

Hi! mark,

On 28 Jul 19 21:14, you wrote to me:

has anyone else noticed that makenl is generating 10 character
serial numbers?

Still okay with MakeNL 3.4.8 (Linux) compiled with GNU C on Oct
20 2018 21:07:21.

interesting... mine is also 3.4.8... compiled 2018 Oct 22 with gcc
(Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0... hummm... are you 32bit or
64bit?

Ahh, forgot... compiled in 32bit 14.04.2 Xubuntu. Oops. It's still running fine on 32bit 18.04.1 Lubuntu, in a vBox VM. I'm not doing any 64bit Fidonet and don't ever intend to.

Cheers,
Paul.

... One good turn gets most of the blanket.
--- GoldED+/LNX 1.1.5-b20130515
* Origin: Quinn's Rock - Live from Paul's Xubuntu desktop! (3:640/1384)

On 2019 Jul 28 14:14:20, I wrote to you:

has anyone else noticed that makenl is generating 10 character serial numbers?

the problem is here... specifically, %08lx does not set the maximum length... only the minimum...

fprintf(MailFILE, "\x01MSGID: %d:%d/%d %08lx\r\n", MyAddress[A_ZONE],
MyAddress[A_NET], MyAddress[A_NODE], GetSequence());

something like this should work but i'm not a C coder and haven't tried to actually compile something to test this with...

char* serialnum = printf("%08lx", GetSequence());
if (strlen(serialnum) > 8)
{
serialnum = serialnum + strlen(serialnum) - 8;
}
fprintf(MailFILE, "\x01MSGID: %d:%d/%d %s\r\n", MyAddress[A_ZONE],
MyAddress[A_NET], MyAddress[A_NODE], serialnum);


)\/(ark

Once men turned their thinking over to machines in the hope that this would set them free. But that only permitted other men with machines to enslave them.
... Why do croutons come in airtight packages? It's just stale bread.
---
* Origin: (1:3634/12.73)

Hello mark!

29 Jul 19 00:21, you wrote to all:

has anyone else noticed that makenl is generating 10 character
serial numbers?

the problem is here... specifically, %08lx does not set the maximum length... only the minimum...

fprintf(MailFILE, "\x01MSGID: %d:%d/%d %08lx\r\n",
MyAddress[A_ZONE],
MyAddress[A_NET], MyAddress[A_NODE], GetSequence());

You are correct. This is only a problem in 64-bit versions, because in 32-bit versions an unsigned long int will never exceed 8 hexadecimal characters.

Thanks for the report; I'll get it fixed.

Andrew

--- GoldED+/LNX 1.1.5-b20180707
* Origin: Phoenix BBS * phoenix.bnbbbs.net (1:320/219)

29 Jul 19 02:34, you wrote to mark lewis:

You are correct. This is only a problem in 64-bit versions, because in 32-bit versions an unsigned long int will never exceed 8 hexadecimal characters.

Thanks for the report; I'll get it fixed.

This is already fixed in 3.5.1.

--- GoldED+/BSD 1.1.5-b20180707
* Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)

Hello mark!

Monday July 29 2019 00:21, you wrote to all:

I am now really confused - I use 3.5.0 compiled on a X64 system and it produces
8 char sequence numbers.

On 2019 Jul 28 14:14:20, I wrote to you:

has anyone else noticed that makenl is generating 10 character
serial numbers?

the problem is here... specifically, %08lx does not set the maximum length... only the minimum...

fprintf(MailFILE, "\x01MSGID: %d:%d/%d %08lx\r\n",
MyAddress[A_ZONE],
MyAddress[A_NET], MyAddress[A_NODE], GetSequence());

something like this should work but i'm not a C coder and haven't
tried to actually compile something to test this with...

char* serialnum = printf("%08lx", GetSequence());
if (strlen(serialnum) > 8)
{
serialnum = serialnum + strlen(serialnum) - 8;
}
fprintf(MailFILE, "\x01MSGID: %d:%d/%d %s\r\n", MyAddress[A_ZONE],
MyAddress[A_NET], MyAddress[A_NODE], serialnum);

)\/(ark

Once men turned their thinking over to machines in the hope that this
would set them free. But that only permitted other men with machines
to enslave them.
... Why do croutons come in airtight packages? It's just stale bread.

Vince

--- Mageia Linux v6 X64/Mbse v1.0.7.12/GoldED+/LNX 1.1.501-b20150715
* Origin: Air Applewood, The Linux Gateway to the UK & Eire (2:250/1)

Hello andrew!

29 Jul 19 21:14, you wrote to me:

You are correct. This is only a problem in 64-bit versions,
because in 32-bit versions an unsigned long int will never exceed
8 hexadecimal characters.

Thanks for the report; I'll get it fixed.

This is already fixed in 3.5.1.

So it is. You've been busy, my friend. ;-)

Andrew

--- GoldED+/LNX 1.1.5-b20180707
* Origin: Phoenix BBS * phoenix.bnbbbs.net (1:320/219)

Re: makenl msgids
By: Vince Coen to mark lewis on Mon Jul 29 2019 12:55:39

I am now really confused - I use 3.5.0 compiled on a X64 system and it

produces

8 char sequence numbers.

check your sequence.dat file and see what it contains... mine is binary at the moment but i've just pulled 3.5.1 and compiled it... i expect mine will be fixed soonish...

FWIW: i'm in the process of hacking in NOKILLSENT to the notify and submit verbs so i/we can turn off the killsent attribute if i/we desire... i decided to make it for each type of msg instead of global because you may want to kill sent notify receipts and/or notify errors... my gripe is that my segments are killed and i want to keep them... no, i don't want to be copying them all over the drive when it is not necessary ;)

)\/(ark
--- SBBSecho 3.08-Linux
* Origin: SouthEast Star Mail HUB - SESTAR (1:3634/12)

On 2019 Jul 29 10:29:58, I wrote to Vince Coen:

FWIW: i'm in the process of hacking in NOKILLSENT to the notify and
submit verbs so i/we can turn off the killsent attribute if i/we
desire... i decided to make it for each type of msg instead of global because you may want to kill sent notify receipts and/or notify
errors... my gripe is that my segments are killed and i want to keep them... no, i don't want to be copying them all over the drive when it
is not necessary ;)

this feature/fix is complete and a patch file is available...

https://sourceforge.net/p/makenl/feature-requests/9/

it has been tested with newly generated nodelist segments and appears to work as desired... more testing is warranted as is oversight by the maintainers...

)\/(ark

Once men turned their thinking over to machines in the hope that this would set them free. But that only permitted other men with machines to enslave them.
... Some performers take pains with their music, others give them.
---
* Origin: (1:3634/12.73)