1. Forum
  2. FidoNet
  3. SYNC SYSOPS

  • Black-on-black doesn't change attributes in Frame.js implementation of

    From Deucе@1:103/705 to GitLab note in main/sbbs on Wed Nov 12 20:27:38 2025
    https://gitlab.synchro.net/main/sbbs/-/issues/1007#note_7872

    The problem appears to be line 391 in frame.js...

    ```javascript
    if(attr)
    this.__properties__.data[py][px].attr = attr;
    ```

    Since (dark) black on black has a value of zero, it doesn't actually get set.

    This change was apparently made in 2011 with commit 72488196a51
    --- SBBSecho 3.31-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Wed Nov 12 20:30:00 2025
    https://gitlab.synchro.net/main/sbbs/-/issues/1007#note_7874

    A simple workaround would be to use *blinking* black on black. :grin:
    --- SBBSecho 3.31-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Josh Renaud@1:103/705 to GitLab note in main/sbbs on Thu Nov 13 07:06:56 2025
    https://gitlab.synchro.net/main/sbbs/-/issues/1007#note_7875

    A better check might be `if(attr !== undefined)`? Or maybe a comparison with the existing attr to see if they're different?

    ```
    if(attr !== undefined && properties.data[x + position.offset.x][y + position.offset.y].attr != attr)
    properties.data[x + position.offset.x][y + position.offset.y].attr = attr;
    ```
    ?
    --- SBBSecho 3.31-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Josh Renaud@1:103/705 to GitLab note in main/sbbs on Thu Nov 13 07:12:16 2025
    https://gitlab.synchro.net/main/sbbs/-/issues/1007#note_7876

    Actually, on second thought, that's probably a bad idea -- `undefined` is used for transparency.

    I should probably try some tests.
    --- SBBSecho 3.31-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)