1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • src/sbbs3/sbbsecho.c

    From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Jan 13 17:04:34 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/55962a410034e3633fe3ff09
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Disable libarchive support for creating/appending bundleslibarchive apparently cannot be used for in-place modification of (e.g. adding files to) existing archives, so if a bundle already exists, this code would over-write it with a new archive containing just the latest packet. Issue reported by acn (IMZADI) via DOVE-Net.I could and might create an update_archive() function which extracts and re-creates an archive with additional files, but since I don't have that yet, just disable this for now and always use an external archive utility to create or update bundles (so again, an "Archive" configuration is required in your sbbsecho.ini file, which you most likely already have).
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/4ec5647c783a5f5af9d68611
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve some Coverity-discovered issueswith lseek() argument types, ftell() return type, etc.Likely none of these would be actual issues with files < 2GiB in size.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Mar 2 10:07:44 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f9a681ac286284fe57f7f5c2
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix possible negative offset to fseeko()CID 350353
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (in GitKraken)@1:103/705 to Git commit to main/sbbs/master on Thu Feb 16 00:01:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/6fb20b919003c805a40c207c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve signed/unsigned compare warning with MSVC
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Sat Feb 18 12:59:30 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/ccfad124e104b09bf825392e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    More consistent 'exact' parameter values to findnodecfg() - e.g. false, not 0No functional change.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From poindexter FORTRAN@1:103/705 to Rob Swindell (on ChromeOS) on Sat Feb 18 18:45:26 2023
    To: Rob Swindell (on ChromeOS)
    @MSGID: <63F18D47.12151.dove.sync_c@realitycheckbbs.org>
    @REPLY: <63F13C32.46548.syncprog@vert.synchro.net>
    @TZ: 41e0
    Re: src/sbbs3/sbbsecho.c
    By: Rob Swindell (on ChromeOS) to Git commit to main/sbbs/master on Sat Feb 18 2023 12:59 pm

    As before, "test results appreciated".

    Thanks for doing this. I'm relying on the nightlies, so I'll download them tomorrow and test.
    ---
    þ Synchronet þ .: realitycheckbbs.org :: scientia potentia est :.
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sat Apr 15 19:45:46 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/227e2f4986eb0b04c05cc6ea
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Stop classifying msgs for unknown areas as security violationsWhen Secure EchoMail is enabled and a Bad Echo Area (*) is defined in thearea file (areas.bbs), but the packet source address is *not* listed as alink to the Bad Echo Area (tag: *) in areas.bbs, any messages for unknownareas in such a packet would cause the pkt to be considered a bad packetwith a security violation. Instead, the message should just be skipped.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Tue May 30 17:27:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b185201161cd35dea8273d84
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Strip the "in-transit" attribute flag from imported packed-messagesLog a warning message when either the "local" or "in-transit" flag has beenstripped from ("Sanitized") imported packed-messages.Keyop reported a chksmb warning on a FidoNet message that contained the'in-transit' attribute:<Keyop> Message flagged as 'In Transit' (?): 1<Keyop> fidonet_fidosoft Message Base has Errors!The message in question appears just to be a corrupted echomail msg comingfrom HPT:Sender '56:43 'To Tommi KoivulaSubject testX-FTN-AREA FIDOSOFT.HUSKYX-FTN-TID hpt/os2-wc 1.9.0-cur 2021-03-14SBBSecho didn't use to convert/import the "in-transit" flag on importednetmail or echomail messages, ... until commit 446ab0ef7e09e5c61cf, whichwas needed to support the TickFix robot. So now, let's just sanitize thepacked-message attributes a little sooner in the import process and log awarning when such sanitization has taken place.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon Jun 26 11:03:44 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e76fafaae4580941b343253b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix type 2.2 packet header generationAs reported by Deon on DOVE-Net: type 2.2 packet generation was not (sinceSBBSecho v3.0) setting the origin and destination point values correctly:was leaving the packet type 2.0 date values in these fields.Also, zero-out the reserved bytes in the type 2.2 packet header (don't leavethe type 2.0 date values in there).Thanks for the report Deon!
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Thu Jul 20 11:53:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/68df9812f31add3f94430d77
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Always delete the AREASxxxxxx temp fileWhen there are no changes (areas added or removed) via an areafix message, thedata/AREASxxxxxx temp file would be left behind. The file was only removed ifareas were added or removed from the area file via areafix message.The orphaned data/AREASxxxxxxx files were reported via DOVE-Net by Gamgee (PALANTIR)If you have these stale files, you can safely delete them.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sun Sep 17 23:27:44 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f9b0dda5a1cac371a50f9f3f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add more detail (e.g. line number) to various "error opening" log msgsSome of the errors could be pretty vague since they looked the same andwe were depending on the path/file attempted to be opened in the log msgto clue us into what exactly was being attempted. But some of these filepaths are sysop-configurable, and they can put unexpected things in therethat make it difficult to determine exactly what file was trying to beopened and for what purpose. This should help a little bit.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Dec 4 21:14:34 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/43fb687f2e138e183f841a42
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix issue when packing netmails for multiple different linked-nodes

    Introduced in commit 15b230af (9 months ago), the first linked-node config (including packet password!) for the first packed netmail message would be reused for subsequent packed netmail messages.

    Thank you to Wilfred van Velzen (2:280/464) for reporting this problem!

    Additional debug-level log message when using a packet password for a newly created packet.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Dec 4 22:57:40 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/28e435bdc2e909f38032afd4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Combine the "new packet" and "password-protected" debug-log lines

    ... to de-clutter the log

    Also, don't log the packet passwords. Folks copy and post sbbsecho.log lines and that could seriously compromise the security of the Interwebs if those super-secret passwords were ever leaked!
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Fri Dec 15 17:25:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/fc9d641054b36d9a84cc87da
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Feb 7 10:47:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/20aecd3a4d979af82e3f509b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix more warnings...

    It looks like we may need a set of PRI?TIME macros for printf()ing
    a time_t.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 16 20:11:36 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9b28769f4b669763409f0435
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Bugfix: actually use the SMB netattr 'HOLD' attribute flag

    ... when exporting from SMB to .msg ("stored message") file
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 23 16:12:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/4c7a908f8ee55161faf3be71
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Insure buf is null-terminated in getzpt(), resoving CID 488308
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 23 17:13:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5a2a73ae1b20ddf3563c23fe
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit to this file
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)