1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • exec/load/binkp.js

    From rswindell@1:103/705 to CVS commit on Fri Apr 10 00:01:24 2020
    exec/load binkp.js 1.122 1.123
    Update of /cvsroot/sbbs/exec/load
    In directory cvs:/tmp/cvs-serv22684

    Modified Files:
    binkp.js
    Log Message:
    When a file fails to open, log the error value, e.g. this:
    Error 24 opening '../fido/outbound/5e7a2520.pkt'. Not sending.
    instead of this:
    Unable to open '../fido/outbound/5e7ab832.pkt'. Not sending.

    Error 24 is "too many open files", btw. Another problem to solve.

    --- SBBSecho 3.10-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Nov 4 10:24:16 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/4dd32231f18bcb4f67833c36
    Modified Files:
    exec/load/binkp.js
    Log Message:
    Resolve undetected or infinitely-retried socket-send failuresMy hub (1:218/700) is currently having what appears to be a TCP/IPconnectivity issue that was resulting in infinite "Send failure"log messages and "We got an M_EOB, but there are still N files pending M_GOT"log messages.I first added better socket-send failure detection (checking return value ofsendCmd() and sendData() where needed) and then noticed that failure to senda file was not detected (the sending.file.position is advanced even ifsendData() fails), so now handling that condition too.Also added more diagnostics around socket-send failures (is socket writable?)in this particular case, the socket is not writable and socket-send isreturning 0.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Nov 28 12:18:48 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/c3a41492a79aa3c6b3a41b37
    Modified Files:
    exec/load/binkp.js
    Log Message:
    More errno details in file open and socket-send failure warning log msgs
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Nov 28 12:57:48 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/0ea1ce1d2600b79a77d41b7e
    Modified Files:
    exec/load/binkp.js
    Log Message:
    Use socket.poll() to check socket for writability before send()This is the real fix for infinite-wait on send() problem that was attemptedin commit f0127e9d457, but caused other issues. Thanks Deuce.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)