1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • src/sbbs3/logon.cpp

    From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon Jul 24 17:21:26 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/8266da9c329d2ba49ff2001c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Log an error if getstats() returns a failureI saw my logon.jsonl file getting cycled multiple times a day recently on Vertand suspect this function call may have been failing.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Mon Jul 24 18:25:34 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e12c35049251dc97e8eafd7c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Revert "Log an error if getstats() returns a failure"This reverts commit 8266da9c329d2ba49ff2001cf542a0d05dc9987e.We're already passing a sock_init callback (ls_cb) which is supposed to setthe socket options (call set_socket_options), so this change shouldn't benecessary and reportedly caused more issues binding ircd sockets when runningircd.js via jsexec (though I didn't see this myself).
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Mon Jul 24 18:27:42 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/46f1f80e75b30d477cdb419c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Revert "Revert "Log an error if getstats() returns a failure""This reverts commit e12c35049251dc97e8eafd7c7fc12dfd9ba13ad9.Wrong commit reverted. Oops.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Wed Sep 13 16:27:22 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/65f1df280bc72439e80b8a9f
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    A todo comment
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Feb 4 18:45:54 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/cbf6a8b24c615e753801dbd2
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    I'm not sure what "node message indices" (data/msgs/*.ixb files) are/were

    I don't recall this actually being a thing, ever, so certainly no reason to
    be cleaning these files up during logon. <shrug>
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Feb 26 23:07:48 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f315f34ce2c8b91e656fc5a4
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Change "On two nodes" to "On more than one node", since it's possible it's > 2 --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Feb 26 23:22:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9544a3c6bf36555a2babc6bb
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't send NodeLoggedOn message to any nodes if user isn't being logged-on

    If user is being kicked off for being on "More than one node at a time", then don't send a message to other any other nodes that the user logged-on successfully (they haven't). Previosuly, it'd send messages to all the lower-numbered nodes that were in-use (but not by the same user).

    Reported by Nelgin.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Sep 20 00:03:30 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c345c6ad034f1e64db2b88de
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Clear the Guest user's language (lang) field during logon - revert to default --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Sep 22 16:57:12 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3bcf61744225d8898eae6a00
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Always close csts.ini file, even in error path (failure to open dsts.ini)

    Fix for CID 509720
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Dec 6 17:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3b602ca5349f2b4143ff27ab
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Check return value of getnodedat()

    Should fix CID 515599 since this seems to be the only place we call unlocknodedat() without possibly not owning the nodefile_mutex already.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Feb 2 23:46:56 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/b6b3e89091f941ab6ba3ea01
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Actually use the (first) shell we found that the user meets the requirements

    As discovered and reported by Deuce and Nelgin
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Feb 16 22:06:52 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/437b1a13e91a9878480671d7
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't backup dsts.ini daily

    Looks like an unintentional debug-inclusion with commit 2064f3a4f71c6656693a1 as pointed about by Deuce in IRC.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Thu May 1 11:57:16 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/9eaeedc13950d1ec26af5963
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Do rollover daily stats (dsts.ini) if the previous date was Jan-1-1970 (never)

    Basically revert commit 2064f3a4f71c6656693a1d24fc63004c3c41aaea

    In a new install, the "Date" value in dsts.ini will be 0/Never and thus would never be rolled over (e.g. stats moved o csts.tab files).

    Since getstats() now reliably detects any read failures, we shouldn't need
    this as a work-around any more anyway - if the "date" field is 0, it just
    means a new install and it's expected.

    This should fix the issue reported by Basis where the ctrl/csts.tab and node*/csts.tab files were never created in fresh install of v3.20. A work around is to just set the Date field in the ctrl/dsts.ini file to the current date (one time).
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Mon May 19 20:12:48 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/ae706b8054af1f291bfcd9ca
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't turn off the "ASCII only" user setting during logon

    ... when auto-terminal-type detection is enabled for the user

    Fix for issue #923
    --- SBBSecho 3.27-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)