1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • DDMsgReader: When viewing message headers, now shows all available mes

    From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Apr 25 22:58:24 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/288#note_3510

    Right, but they're not defined for a reason: you'll never encounter them. A message header's field_list property will only ever contain the following header field types (from js_msgbase.c):``` case SMB_COMMENT: case SMB_POLL_ANSWER: case SMB_GROUP: case FIDOCTRL: case FIDOSEENBY: case FIDOPATH: case RFC822HEADER: case RFC822TO: case RFC822CC: case RFC822ORG: case RFC822FROM: case RFC822REPLYTO: case RFC822SUBJECT: case SMTPRECEIVED: case UNKNOWNASCII:```So it seems like you're adding a whole bunch of code for no apparent reason. <shrug>
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Apr 25 23:09:24 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/288#note_3511

    Is there a reason you have both the "FTN_REPLY" and "X-FTN-REPLY" - are you actually seeing both of these in existence? I don't don't recall use dashes in property names, but I'm also not totally following this code either.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Wed Apr 26 09:22:30 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/288#note_3512

    Naturally, I wouldn't want to add code for no reason. I had trimmed this down after your earlier comments, but I may have misunderstood a previous comment where you had mentioned looking at smb_fieldtype() in src/smblib/smbstr.c (those are probably not for field_list, I imagine?). I'll trim this down further to the ones you've mentioned above.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Wed Apr 26 09:29:14 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/288#note_3513

    The following are not defined in smbdefs.js - Should these be?SMB_GROUPRFC822TORFC822CCRFC822ORGRFC822FROMRFC822REPLYTORFC822SUBJECTUNKNOWNASCII
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Wed Apr 26 09:37:26 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/288#note_3514

    I seem to remember seeing both of those in some messages years ago when I originally wrote this.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Wed Apr 26 10:48:38 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/288#note_3517

    Yeah, I'll add those to smbdefs.js. Haven't had a need/use-case before now. Some of these header fields (e.g. SMB_GROUP, UNKNOWNASCII) have never been used, so you'd never actually see one in a message.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Wed Apr 26 10:50:26 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/288#note_3518

    If propName in this context is an actual JS property name (of a msg header), then, you'll never see "X-FTN-*" - so that doesn't make sense to me.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)