https://gitlab.synchro.net/main/sbbs/-/commit/596369dcc45b8352c6ed3c0c
Modified Files:
src/doors/syncscumm/PROVENANCE.md build.sh src/doors/syncscumm/scummvm/engines/dialogs.cpp
Log Message:
syncscumm: identify the door and its build on the Global Main Menu
SyncSCUMM identified itself nowhere. No version, no build stamp, no site --
a player saw stock ScummVM's name and version and nothing to say which door,
or which build, they were talking to. Every sibling door has carried that
for a long time: syncdoom and syncduke in the corners of their menus, syncconquer appended to the engine's own version line, syncretro on its
splash.
That is not only cosmetic. Seven of the eight ScummVM game installs on this system were quietly running a binary four days and several batches old, and nothing on screen could have revealed it.
The GMM's two heading lines now carry the door's identity instead of
ScummVM's:
SyncSCUMM v0.1
~c6d429e940 synchro.net
Nothing is lost. The About button on that same menu still shows ScummVM's
full version and attribution, and since the launcher is compiled out of the door (SYNCSCUMM_NO_LAUNCHER) the GMM was already the only route to it.
NO BUILD DATE ON THAT LINE, deliberately. The widget is 160px in the lowres layout and 210 highres -- roughly 26 characters -- and hash + date + site
ran to 36, so the GUI ellipsized it and ate the middle. The hash alone identifies the build exactly; the date only made it approximately
informative, and a truncated stamp is worse than a short one.
The hash and date come from the SHARED Synchronet stamp
(build/gitinfo.cmake) rather than a hand-rolled git call, so this door
reports its build exactly like the siblings -- including the part that
matters most for the staleness problem above: a dirty tree reads "~hash" and dates itself to the build, so a stamp never names a commit the binary does
not contain.
Bridging that across this door's two-stage build took one line each: stage-1 CMake builds the door libraries, but stage 2 is ScummVM's own
configure/make, which never sees CMake. build.sh runs gitinfo.cmake in
script mode and appends the generated header's directory to config.mk's INCLUDES, the same mechanism already used to reach termgfx and xpdev.
PROVENANCE.md records engines/dialogs.cpp as the sixth modified upstream
file.
Co-Authored-By: Claude Opus 4.8 (1M context) <
noreply@anthropic.com>
--- SBBSecho 3.37-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)